Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Hydra build support for multiple devices #40

Closed
wants to merge 1 commit into from
Closed

Adds Hydra build support for multiple devices #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions release.nix
View file
Open in desktop
@@ -0,0 +1,5 @@
{ devices ? [ "google-blueline" ] }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could default to "all devices"? Something like

builtins.filter (d: builtins.pathExists (./. + "/${d}/default.nix")) (builtins.attrNames (builtins.readDir ./.))


with import <nixpkgs> {};

lib.genAttrs devices ( device: (import ./. { inherit device; }).build.android-bootimg)
Copy link
Member

@samueldr samueldr Oct 30, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achtung! Not all devices are android-based!

Though re-reading my system types, I see we need a couple well-known universal attributes. (This is on me to implement)

  • disk-image (already present in depthcharge) a full disk image with stage-2 and stage-1. Not applicable to all devices
  • stage-2, basically system.img for android-based devices. Most often not possible to cross-compile
  • stage-1, could be called initramfs or initrd, but those terms are confused and confusing.

This way, we could always try, by default, and build stage-1, stage-2 and disk-image on release, both as cross (on x86_64) or native (aarch64).

Any suggestions for better well-known attribute names? I'm thinking stage-1 and stage-2 without other qualifier could clash... Maybe something like stage-n.img?