[WIP] pine64-pinephonepro: Init #445

samueldr · 2021-12-20T03:48:36Z

TODO

Try building a "normal" and modular NixOS-flavoured kernel
Write instructions

Outdated instructions...

Quick install guide

This will overwrite anything on the target eMMC and SD cards.

First, neuter the pre-installed system on the eMMC of the Pinephone Pro.

This will use the temporary installer script, here's the command to build the "hello" example system.

 $ nix-build --argstr device pine64-pinephonepro -A outputs.temp-tow-boot-install-script examples/hello/

Build Tow-Boot from Phone and tablet UX + mmcboot support Tow-Boot/Tow-Boot#67
```
 $ nix-build -A pine64-pinephonePro
```

Write Tow-Boot to an SD card (via e.g. dd)

sudo dd if=result/shared.disk-image.img of=/dev/sdXXX bs=8M oflag=direct,sync

Insert the SD card in the Pinephone Pro, and boot it while holding Volume Up, making sure your Pinephone Pro is connected via USB to your computer. The LED will turn blue when in USB Mass Storage mode.

Write Tow-Boot to the eMMC (via e.g. dd)

 $ sudo dd if=result/shared.disk-image.img of=/dev/sdXXX bs=8M oflag=direct,sync

Remove the SD card. We will make sure the installation to eMMC is successful.
Reboot the Pinephone Pro by holding power, press Volume Up when it's booting back up so it boots again in USB Mass Storage mode.

"Install" to the eMMC via the installer script:

 $ sudo /nix/store/[...]-temp-tow-boot-install/install.sh /dev/sdXXX

Once the script is done, you can reboot the device by holding the power button. You don't need to hold any of the volume keys to continue booting in the Mobile NixOS system.

Updating the boot partition

Simple!

Boot the device to USB Mass Storage by holding Volume Up.
Write (dd) the boot partition to what should be the fourth partition in a "normal" setup.

NAQ (never asked questions)

Why's this so damned hard?

Actually this is not much harder than "just" using dd to write an SD card with, let's say, Target Disk Mode, and then "just" using dd to write to the eMMC now attached via USB.

The main added weirdness is managing the platform firmware separately.

This is done to better exercise planning for a better NixOS on ARM. If it can work on "complex" devices like a phone, surely it'll be trivial on a "boring" SBC!

Additionally, some of the steps outlined here are universal for any distribution that will not distribute the platform firmware bundled into their system images.

Finally, this is a temporary measure.

The permanent solution will be an installer system. The user will write Tow-Boot to the eMMC, and boot from a universal SD card that holds an installer system that will guide the user through some questions about partitioning (e.g. ask about FDE and filesystems), the preferred graphical environment, and then do a "classic" opinionated
nixos-install under the covers.

samueldr · 2021-12-20T05:37:15Z

modules/hardware-rockchip.nix

+    hardware.socs.rockchip-rk3399s.enable = mkOption {
+      type = types.bool;
+      default = false;
+      description = "enable when SOC is RK3399";


Suggested change

description = "enable when SOC is RK3399";

description = "enable when SOC is RK3399s";

samueldr · 2021-12-20T05:37:40Z

modules/kernel-config.nix

+        RD_GZIP = yes;
+        RD_XZ = yes;
+


Move this change (and related normalization) into a new PR.

telent · 2022-01-06T22:06:12Z

I believe that

$ nix-build --argstr device pine64-pinephonepro -A outputs.temp-tow-boot-install-script examples/hello/

in these instructions should be

$ nix-build --argstr device pine64-pinephonepro -A outputs.u-boot.temp-tow-boot-install-script examples/hello/

(there's a u-boot in the attribute path)

samueldr · 2022-01-06T23:08:26Z

The system type's outputs are copied into the main outputs attrset.

mobile-nixos/lib/eval-with-configuration.nix

Lines 48 to 49 in 796040d

    
           # Merge the system-type outputs at the root of the outputs. 
        
           outputs = eval.config.mobile.outputs // eval.config.mobile.outputs.${eval.config.mobile.system.type};

So while you're right that the attribute exists under the outputs.u-boot namespace, it also exists at the root level. This is because of backward compatibility.

tomfitzhenry · 2022-01-11T14:36:48Z

This works great for me, thanks!

I like the idea and execution of Tow-Boot.

devices/pine64-pinephonepro/default.nix

samueldr · 2022-05-30T03:48:22Z

Thank you @wentam for some of the changes.

Rebased, dropped needless changes from the history. Still WIP.

wentam · 2022-05-30T06:37:53Z

Perhaps we should run this patch as well? I've been running that patch for a couple of days and it makes the charging situation much better.

samueldr · 2022-05-30T16:53:14Z

Perhaps we should run this patch as well? I've been running that patch for a couple of days and it makes the charging situation much better.

Probably!

samueldr · 2022-05-30T19:17:20Z

Two changes:

Added the suggested change set for charging, and I'm observing that indeed it won't get stuck in a state where it's stating it's charging, but actually drawing 0A (from a USB power monitor).
Added a workaround for what I consider a bug/regression in mainline Linux and CONFIG_LOGO

What's that about CONFIG_LOGO? I've found that upstream seems intent on making sure the kernel logo is never used anymore at all. I don't know where in the stack it happens, but display init is being deferred in a way that is detrimental to user experience in my opinion.

I assume the goal is that, with blinders on, you'll see it makes sense to defer changing the display mode until needed as it prevents needless flickers during boot, e.g. your normal UEFI x86_64 laptop will continue showing its splash until some userspace component draws to the display.

Here this is not ideal since there is no display init done by the platform firmware. Having some sort of feedback early on that things are happening is good.

Though even if we had feedback from the platform firmware, I would argue that being able to control this behaviour would be beneficial here as we would want to show it ASAP to actually show "yes the kernel is booting"; otherwise if it crashes really early it will look like the platform firmware is hanging, when in reality it's happening somewhere between kernel init and userspace init.

This is probably a change that we want to investigate into applying overall to all platforms.

…===========

Config is the defconfig from mobian, arbitrarily changed.

This is based on the pinebook pro firmware package. Unknown of this is all of the required firmware, and if there's too much.

This is used to force the type-c direction.

And change origin to the now decided location of the community maintained kernel.

See https://gitlab.com/pine64-org/linux/-/merge_requests/36 TLDR: chip too hot, designed to run cooler slower.

See: - https://gitlab.com/pine64-org/linux/-/merge_requests/34

This serves more to prove to me that it actually should be working. What needs to actually be done is figure out *what* is preventing the logo from showing. Note that this is not a Pinephone Pro issue, nor is it an RK3399 issue, nor is it an ARM issue. This workaround had been authored for an x86_64 system initially.

tomfitzhenry · 2022-06-03T03:07:15Z

Perhaps we should run this patch as well? I've been running that patch for a couple of days and it makes the charging situation much better.

@wentam It's good to hear that that MR improves things. Consider leaving a comment on that MR with your experiences, to allow a reviewer to have confidence in the change.

samueldr added the 4. type: port New device port label Dec 20, 2021

This was referenced Dec 20, 2021

Phone and tablet UX + mmcboot support Tow-Boot/Tow-Boot#67

Merged

PinePhone Pro support #440

Closed

samueldr commented Dec 20, 2021

View reviewed changes

iclanzan reviewed Feb 1, 2022

View reviewed changes

devices/pine64-pinephonepro/default.nix Outdated Show resolved Hide resolved

iclanzan mentioned this pull request Feb 7, 2022

Stage 1 freezes with tmpfs root filesystem #461

Open

samueldr added the 1. device: pinephone/pro label Mar 5, 2022

tomfitzhenry mentioned this pull request Mar 23, 2022

2021.10-004 pine64-pinephonePro: flash to SPI -> "unrecognized JEDEC id bytes: ff ff ff ff ff ff" Tow-Boot/Tow-Boot#121

Closed

samueldr marked this pull request as draft May 23, 2022 19:36

samueldr force-pushed the wip/pinephone-pro branch from 22891f1 to b5b115f Compare May 30, 2022 03:47

samueldr added 12 commits May 30, 2022 17:17

=====================================================================…

adb2b89

…===========

kernel-config: Enable RD_GZIP/XZ

eaae7c8

kernel-config: Set FW_LOADER_USER_HELPER_FALLBACK=n

86ad369

kernel-config: Use HZ_1000

4283443

kernel-config: Restart on panic

e32cc71

=====================================================================…

15f1c4a

…===========

hardware-rockchip: Add rockchip-rk3399s

494cdc5

pine64-pinephonepro: Init kernel

cb90552

Config is the defconfig from mobian, arbitrarily changed.

pine64-pinephonepro: Add firmware

767829a

This is based on the pinebook pro firmware package. Unknown of this is all of the required firmware, and if there's too much.

pine64-pinephonepro: Add USB role switch task

9d98abb

This is used to force the type-c direction.

pine64-pinephonepro: Init

cf20f4a

pine64-pinephonepro: Enable default LED behaviour

efb1554

samueldr and others added 11 commits May 30, 2022 17:17

pine64-pinephonepro: WIP kernel config validation

a867978

pine64-pinephonepro: WIP shell on stage-1 fail

aa7b25b

pine64-pinephonepro: Update kernel to 5.16.0

0276969

And change origin to the now decided location of the community maintained kernel.

pine64-pinephonepro: vibrator support

4b0197f

pine64-pinephonepro: audio support

6927058

pine64-pinephonepro: kernel 5.16.0 → 5.16.7

5e8542c

pine64-pinephonepro: Use appropriate frequency scaling

b1cb422

See https://gitlab.com/pine64-org/linux/-/merge_requests/36 TLDR: chip too hot, designed to run cooler slower.

pine64-pinephonepro: ensure SPI config is enabled

7802617

pine64-pinephonepro: Normalize kernel config

956417b

pine64-pinephonepro: Add charging workarounds

d842ed6

See: - https://gitlab.com/pine64-org/linux/-/merge_requests/34

samueldr force-pushed the wip/pinephone-pro branch from 8c15783 to e8ffe9b Compare May 30, 2022 21:17

fx-chun added a commit to fx-chun/mobile-nixos that referenced this pull request Jun 26, 2022

===== NixOS#445 pine64-pinephonepro =====

617c063

wentam mentioned this pull request Oct 17, 2022

pine64-pinephonepro: Init #535

Merged

25 tasks

samueldr changed the base branch from master to development September 14, 2023 21:47

samueldr closed this Sep 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] pine64-pinephonepro: Init #445

[WIP] pine64-pinephonepro: Init #445

samueldr commented Dec 20, 2021 •

edited

samueldr Dec 20, 2021

samueldr Dec 20, 2021

telent commented Jan 6, 2022

samueldr commented Jan 6, 2022

tomfitzhenry commented Jan 11, 2022 •

edited

samueldr commented May 30, 2022 •

edited

wentam commented May 30, 2022

samueldr commented May 30, 2022

samueldr commented May 30, 2022 •

edited

tomfitzhenry commented Jun 3, 2022 •

edited

	description = "enable when SOC is RK3399";
	description = "enable when SOC is RK3399s";

[WIP] pine64-pinephonepro: Init #445

[WIP] pine64-pinephonepro: Init #445

Conversation

samueldr commented Dec 20, 2021 • edited

TODO

Quick install guide

Updating the boot partition

NAQ (never asked questions)

Why's this so damned hard?

samueldr Dec 20, 2021

Choose a reason for hiding this comment

samueldr Dec 20, 2021

Choose a reason for hiding this comment

telent commented Jan 6, 2022

samueldr commented Jan 6, 2022

tomfitzhenry commented Jan 11, 2022 • edited

samueldr commented May 30, 2022 • edited

wentam commented May 30, 2022

samueldr commented May 30, 2022

samueldr commented May 30, 2022 • edited

tomfitzhenry commented Jun 3, 2022 • edited

samueldr commented Dec 20, 2021 •

edited

tomfitzhenry commented Jan 11, 2022 •

edited

samueldr commented May 30, 2022 •

edited

samueldr commented May 30, 2022 •

edited

tomfitzhenry commented Jun 3, 2022 •

edited