-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement variable resolution for autocompletion and simple references #63
Conversation
WIP implement variable resolution and auto completion
I created MP-5498 regarding the build failure caused by the Plugin Verifier. BTW, I currently also have an issue with running the Plugin Verifier locally. Although I am not sure what causes the issue, I created JetBrains/intellij-platform-gradle-plugin#1389 to track it. |
I am currently not sure how to implement named elements with the more complex attribute paths in Nix: https://intellij-support.jetbrains.com/hc/en-us/community/posts/13471772525330-How-to-implement-PsiNamedElement-with-complex-identifiers-
The previous commit introduced NixInheritedName and NixTypes.INHERITED_NAME, but did not update the tests accordingly.
Interpreter?
I will close this PR. I learned a lot about the API of IntelliJ while working on this, and I think I was going in the wrong direction at the beginning. I will therefore try to restart my efforts with all of what I have learned. See also this conversation with someone from JetBrains. I already applied some of the things discussed in the conversation within this PR, but it is kind of a mess with all the changes I did previously. My PR #74 will integrate some of the generic changes I made from this PR. This PR may still contain other useful classes I may cherry-pick later, but we will see. |
Within this PR, I tried to refactor some code in preparation for simple references and autocompletion. I am not yet sure if this is a good approach. I may continue with the implementation when I have time for it again. Please feel free to write a comment if there is anything you want to discuss.