Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with removed from first line #213

Merged
merged 4 commits into from Jun 2, 2023
Merged

Conversation

henrik-ch
Copy link
Contributor

Nix example file no longer starts with with (import {});

It's an attempt to better follow style guidelines for how to write nix expressions.

example no longer starts with with (import <nixpkgs> {});
@henrik-ch henrik-ch self-assigned this Jun 1, 2023
@henrik-ch
Copy link
Contributor Author

I didn't notice the section about the inherit first. Now I am a bit more skeptical about this change.

@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Jun 1, 2023

Yeah, it's a good occasion to point out what inherit means, we shouldn't remove it. But you can keep the let ... in and use inherit (pkgs) ... - that's already much better because it's clear where names come from.

@henrik-ch henrik-ch marked this pull request as draft June 1, 2023 11:03
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@henrik-ch
Copy link
Contributor Author

Thanks @fricklerhandwerk , I felt that there had to be a better way of doing it, but I couldn't work out what it was.

Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@fricklerhandwerk fricklerhandwerk marked this pull request as ready for review June 2, 2023 15:28
@fricklerhandwerk
Copy link
Contributor

Good to go for me.

@fricklerhandwerk fricklerhandwerk merged commit 29e1e27 into NixOS:master Jun 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants