Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare build/deployment failures following flake-ification #772

Closed
yukiisbored opened this issue Oct 24, 2023 · 10 comments
Closed

Cloudflare build/deployment failures following flake-ification #772

yukiisbored opened this issue Oct 24, 2023 · 10 comments
Labels
bug site Improvements to the site infrastructure or content presentation

Comments

@yukiisbored
Copy link
Member

yukiisbored commented Oct 24, 2023

Observations
Cloudflare builds has started failing post c3c97f8.

See the following:

Problem

Cloudflare builds are failing for some reason. I cannot consult the build logs as it is behind Cloudflare.

Approaches

Willing to help?

I'm able to move the deployment process to GitHub actions once the automated Cloudflare deployment is disabled.

Priorities

Add 👍 to issues you find important.

@yukiisbored yukiisbored added bug site Improvements to the site infrastructure or content presentation labels Oct 24, 2023
@yukiisbored
Copy link
Member Author

Couple of examples of the site not updating. as of writing:

@yukiisbored
Copy link
Member Author

yukiisbored commented Oct 24, 2023

@NixOS/infra Could you please pull the build logs from Cloudflare Pages so we can fix the build failure? Thanks.

@delroth
Copy link
Contributor

delroth commented Nov 2, 2023

@yukiisbored taking this over on the infra side of things. Sorry for the latency, the people who have time didn't have the access (now fixed), the people who have the access don't have time :)

Is there any special attachment to Cloudflare pages for nix.dev? ~all of the static websites for Nix are currently using Netlify (e.g. nixos.org, search.nixos.org, etc.) and if possible I'd like to avoid fragmenting this further. If there are good reasons to stay on Cloudflare Pages ofc then I'll see how we can make this work.

@fricklerhandwerk
Copy link
Collaborator

No reason that binds us to Cloudflare. All we need is to dump a file system tree to be served.

@delroth
Copy link
Contributor

delroth commented Nov 2, 2023

Alright, then unless someone objects I'll try to replicate the search.nixos.org setup, aka. build + deploy to Netlify via a GH Action (which should allow you to do whatever you want build-wise, incl. via Nix, incl. using stuff like Cachix), as well as PR previews.

I'll set that up on a staging domain for now, then once everything seems to be working there we can figure out how to switch nix.dev to point to Netlify.

@delroth
Copy link
Contributor

delroth commented Nov 2, 2023

https://nix-dev-staging.nixos.org/ can you check that everything seems to be as expected?

@fricklerhandwerk
Copy link
Collaborator

@delroth looks good, thanks for the quick help!

@delroth
Copy link
Contributor

delroth commented Nov 3, 2023

This can be closed - master pushes now get properly pushed to nix.dev.

Note that there is still an issue with pull request previews, it needs to be fixed by someone who has admin rights on the repo. @zimbatm has already been informed, but if someone else happens to have admin rights, ping me on Matrix and I can tell you the setting that needs to be flipped.

@yukiisbored
Copy link
Member Author

@delroth Could you or someone else who has access to Cloudflare disable the Cloudflare page? It marks the commits as failing. Example: 3f5c86d

@zimbatm
Copy link
Member

zimbatm commented Nov 8, 2023

Cleared out Cloudflare, the account is now completely empty.

@zimbatm zimbatm closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug site Improvements to the site infrastructure or content presentation
Projects
None yet
Development

No branches or pull requests

4 participants