Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarative reproducible developer environments #256

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

worktheclock
Copy link
Contributor

RITZA language edit.

Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for a review.

This is really good, thank you very much!

PS: Please do the CLA thing so I can merge this.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-06-26-documentation-team-meeting-notes-58/29666/1

@proofconstruction
Copy link
Contributor

proofconstruction commented Jun 27, 2023

I guess we have a setting to automatically request review when force pushing or something?

Anyway, I rebased* the original commit onto master and made several mostly-small changes to the prose as well as larger changes to the way some things are discussed, in particular:

  • more information in the introduction describing why this tutorial differs from the ad-hoc developer environments,
  • better explaining why the declarative approach is (more) useful,
  • better motivating the shell.nix customization, and
  • using more precise language to describe what's happening

*- I hope I did this correctly; I can't tell whether the first commit by the original author was preserved, or if I accidentally included some of my changes to the file that got committed there. Apologies if so.

@proofconstruction proofconstruction removed the request for review from domenkozar June 27, 2023 18:17
Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work!

@fricklerhandwerk fricklerhandwerk merged commit 924b25d into NixOS:master Jun 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants