-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative reproducible developer environments #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long for a review.
This is really good, thank you very much!
PS: Please do the CLA thing so I can merge this.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-26-documentation-team-meeting-notes-58/29666/1 |
RITZA language edit.
70e679c
to
26e6130
Compare
I guess we have a setting to automatically request review when force pushing or something? Anyway, I rebased* the original commit onto master and made several mostly-small changes to the prose as well as larger changes to the way some things are discussed, in particular:
*- I hope I did this correctly; I can't tell whether the first commit by the original author was preserved, or if I accidentally included some of my changes to the file that got committed there. Apologies if so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work!
RITZA language edit.