Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise pinning nixpkgs #303

Closed
wants to merge 9 commits into from
Closed

revise pinning nixpkgs #303

wants to merge 9 commits into from

Conversation

olafklingt
Copy link
Contributor

remove pinning nixpkgs reference
separate pinning nixpkgs from dependency management using niv

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@olafklingt olafklingt changed the title revise pinning nixpkgs WIP revise pinning nixpkgs Aug 11, 2022
@olafklingt
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@olafklingt
Copy link
Contributor Author

recheck

@olafklingt
Copy link
Contributor Author

After writing "I keep a note for myself that the “pinning reference” needs some work." i made this draft today. It is mostly based on nix.dev material written by @domenkozar I would like to know if you agree this PR is going into right direction (as outlined by @fricklerhandwerk ).

source/tutorials/pinning-nixpkgs.md Outdated Show resolved Hide resolved
source/tutorials/pinning-nixpkgs.md Outdated Show resolved Hide resolved
- Using the command line parameter `-I URL` to most of commands like `nix-build`, `nix-shell`, etc <!-- link to ??? tutorial -->
- Using [builtins.fetchTarball](https://nixos.org/manual/nix/stable/expressions/builtins.html) function that fetches the `URL` at evaluation time <!-- more precise link would be nice -->

Possible `URL` values are:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL is a bit inaccurate since it can also be a local path

Copy link
Contributor Author

@olafklingt olafklingt Aug 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is referring here only to the use in nixpkgs=URL like a variable name. I think it is clear within the context?

Comment on lines 42 to 43
- Pinned to a specific commit: `https://github.com/NixOS/nixpkgs/archive/addcb0dddf2b7db505dae5c38fceb691c7ed85f9.tar.gz`
- Using latest channel, meaning all tests have passed: `http://nixos.org/channels/nixos-21.05/nixexprs.tar.xz`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these aren't equivalent. For one, the nixexprs.tar.xz has the programs.sqlite file which contains an index for which package contains which binaries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing out

Copy link
Contributor Author

@olafklingt olafklingt Aug 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which are not equivalent?

commit tar.gz and nixos.org tar.gz ?

or

nixos.org and github.com tar.gz that are referring to a release?

source/tutorials/pinning-nixpkgs.md Outdated Show resolved Hide resolved
olafklingt and others added 7 commits August 25, 2022 22:01
remove pinning nixpkgs reference
separate pinning nixpkgs from dependency management using niv
Co-authored-by: Silvan Mosberger <github@infinisil.com>
Co-authored-by: Silvan Mosberger <github@infinisil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants