working on #PR 325 - nix shell and shellbang #427
Conversation
henrik-ch
requested review from
domenkozar and
fricklerhandwerk
as code owners
|
I see that the CI (continuous integration) is failing, is that something that needs to be fixed for the PR to be valid? |
|
I have no issue with you assuming charge of this PR. I would consider expanding more on the |
|
Thank you for giving feedback and guidance here @n8henrie. The info that I have found on the --pure parameter is on this webpage: If you know of a different/better source than that man page linked above, I am of course very happy to hear about that too. |
I wasn't asked, but still: Definitely link, to unambiguously keep a single source of truth. In case the manual doesn't do a good-enough job, let's improve the manual. |
I tried to follow this advice. Please let me know if you see any further changes on this. |
|
On another note - I am tempted to suggest changing the heading of this tutorial: Current heading: New heading suggestion: Please do thumbs up or thumbs down as a quick feedback on this comment/suggestion. |
| ```shell | ||
| #!/usr/bin/env nix-shell | ||
| #! nix-shell -i bash --pure | ||
| #! nix-shell -p cacert curl jq python3Packages.xmljson |
There was a problem hiding this comment.
Please also include -p bash; while implicit in this case (it is included by something else), this omission in the prior tutorial led to me wasting a fair chunk of my time! See also: https://discourse.nixos.org/t/nix-shell-shebang-default-nix-no-such-file-or-directory/24246/2?u=n8henrie
EDIT: (Adding -p bash was the main reason I was tagged to contribute to this PR :) thanks for picking up and running with it!)
There was a problem hiding this comment.
Thank you for the feedback Nathan, this is included now.
|
I think this may be ready to be included now. I was thinking of adding instructions on how to find versions for pinning nixpkgs, but I will omit that as I believe it would fit better under source/reference/pinning-nixpkgs.md |
|
I'll get back to reviewing this once #325 is merged. |
|
As the original PR has now been merged, this one can be closed. |
|
#325 is merged, please rebase. I try to make time a review next week, but no promises. Edit: @henrik-ch Seems we missed each other closely. You had a valuable addition there, please rebase so we can incorporate that. |
henrik-ch
force-pushed
the
shebang-tutorial
branch
from
17e3318
to
9e64bbc
Compare
|
Took some extra steps to get a sensible merge to current master, but I think this should be okay now. |
There was a problem hiding this comment.
This still needs to update the provenance of commands, since you added bash and cacert. Probably you should say that adding the interpreter package is required to make sure the exact right version is used.
Now that NixOS/nixos-search#610 is merged we can actually tell people to just use search.nixos.org to find what they need. Thanks a lot @ncfavier!
We could add right after that line:
Use [search.nixos.org](https://search.nixos.org/packages) to find packages providing the program you need.
as suggested by @fricklerhandwerk. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
suggestions by @fricklerhandwerk.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-44/25546/1 |
I hope that I am not committing a faux pas here.
This is basically the work from @rapenne-s with the comments and suggested changes from @fricklerhandwerk and @n8henrie. The reason that I started a new PR was that I wasn't sure how to continue inside the #325 itself.