Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learning journey contribution guidelines #596

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

zmitchell
Copy link
Contributor

This PR adds materials for guiding contributors towards the workflow we'd like them to follow when submitting outlines and drafts of the tutorials in the learning journey tutorial series.

@zmitchell
Copy link
Contributor Author

The check that's failing here is complaining about the tutorial template not being included in the toctree. I'm wondering if we can somehow whitelist that since I think this is where the template belongs. Otherwise I can move the template to a different directory.

@infinisil infinisil marked this pull request as draft June 19, 2023 14:26
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-06-15-learning-journey-working-group-meeting-notes-13/29333/1

@zmitchell zmitchell marked this pull request as ready for review June 28, 2023 02:34
@fricklerhandwerk
Copy link
Collaborator

Looks good, also you know best given it's for internal use. Needs a rebase.

@zmitchell
Copy link
Contributor Author

Apparently it's been a while since I pulled upstream so I see that the "Guidelines" section now lives in a "Writing Style" document. I think it makes sense to merge that document with style-guide.md, so I'll do that and request another review.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-06-learning-journey-working-group-meeting-notes-16/30210/1

@zmitchell
Copy link
Contributor Author

This build is currently failing because of a 502 bad gateway on bob.build in influences.md. It's not clear to me whether that link is temporarily broken or just dead. Either way I'm not sure it should block this PR.

@zmitchell zmitchell merged commit e125dd4 into NixOS:master Jul 13, 2023
1 check passed
fricklerhandwerk added a commit to fricklerhandwerk/nix.dev that referenced this pull request Aug 28, 2023
@zmitchell something went wrong a while ago. the changes from NixOS#607 got
overwritten with those from NixOS#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants