-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a summary of the Diataxis framework #634
Add a summary of the Diataxis framework #634
Conversation
Great stuff @zmitchell! I made some suggestions which slightly reword and rearrange a few sections, fix typos, and better coordinate the style throughout. |
Overall, LGTM. Just a couple of nitpicky suggestions. |
I don't see your comments anywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see your comments anywhere
Ah yes, it helps if I actually click the button to submit the review. Here we go
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-10-documentation-team-meeting-notes-62/30291/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-13-documentation-team-meeting-notes-63/30450/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-27-documentation-team-meeting-notes-67/30998/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-31-documentation-team-meeting-notes-68/31127/1 |
b03b626
to
0aeb294
Compare
0aeb294
to
35c1df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on discussion in the LJWG
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-08-10-learning-journey-meeting-notes-21/31556/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-08-14-documentation-team-meeting-notes-72/31722/1 |
Closes #627