Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a summary of the Diataxis framework #634

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

zmitchell
Copy link
Contributor

Closes #627

@proofconstruction
Copy link
Contributor

Great stuff @zmitchell! I made some suggestions which slightly reword and rearrange a few sections, fix typos, and better coordinate the style throughout.

@yukiisbored
Copy link
Member

yukiisbored commented Jul 10, 2023

Overall, LGTM. Just a couple of nitpicky suggestions.

source/contributing/documentation.md Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
@zmitchell
Copy link
Contributor Author

Great stuff @zmitchell! I made some suggestions which slightly reword and rearrange a few sections, fix typos, and better coordinate the style throughout.

I don't see your comments anywhere

Copy link
Contributor

@proofconstruction proofconstruction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see your comments anywhere

Ah yes, it helps if I actually click the button to submit the review. Here we go

source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
source/contributing/documentation.md Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-10-documentation-team-meeting-notes-62/30291/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-13-documentation-team-meeting-notes-63/30450/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-27-documentation-team-meeting-notes-67/30998/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-31-documentation-team-meeting-notes-68/31127/1

Copy link
Contributor

@proofconstruction proofconstruction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on discussion in the LJWG

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-08-10-learning-journey-meeting-notes-21/31556/1

@proofconstruction proofconstruction merged commit d3ae108 into NixOS:master Aug 11, 2023
1 check passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-08-14-documentation-team-meeting-notes-72/31722/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page describing current understanding of Diataxis framework as related to nix.dev structure
7 participants