Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain chained script interpreter #663

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Conversation

zmitchell
Copy link
Contributor

This is a duplicate of #527 with suggestions applied. That PR is stuck so I've moved it here to merge.

alper and others added 3 commits July 27, 2023 08:59
> The chained script interpreter to be invoked

Chained is mentioned here but then also forgotten about: https://nixos.org/manual/nix/unstable/command-ref/nix-shell.html

Mostly it's unclear here why there are multiple weird hashbang lines there that are the same.

Also it's not great that here an entirely new construct is introduced that probably nobody will have ever seen before and to understand what it does you have to go to several different off-site documentation pages.

Can this be rewritten to be more standalone?
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 808ac3b
Status: ✅  Deploy successful!
Preview URL: https://e6e13bfa.nix-dot-dev.pages.dev
Branch Preview URL: https://chained-script-interpreter.nix-dot-dev.pages.dev

View logs

@zmitchell zmitchell merged commit 0d6c103 into master Jul 27, 2023
3 checks passed
@fricklerhandwerk fricklerhandwerk deleted the chained-script-interpreter branch October 9, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants