Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the context for the installation script to match the example … #793

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

iCre8
Copy link
Contributor

@iCre8 iCre8 commented Nov 7, 2023

minor changes to the steps needed to create a scripted development environment

@iCre8 iCre8 requested a review from a team as a code owner November 7, 2023 20:22
Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks a lot. Always rewarding if someone reads the stuff and cares enough to fix errors. :)

source/tutorials/first-steps/declarative-shell.md Outdated Show resolved Hide resolved
@fricklerhandwerk fricklerhandwerk merged commit fcac94d into NixOS:master Nov 9, 2023
4 checks passed
@@ -32,7 +32,7 @@ In this tutorial we'll take a look how to create reproducible shell environments

## Entering a shell with Python installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been updated, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Entering a shell with Python installed
## Entering a shell with Git, Neovim, and Node.js installed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, right, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants