Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first lesson for the new module tutorials. #982

Merged
merged 2 commits into from
May 23, 2024
Merged

Add first lesson for the new module tutorials. #982

merged 2 commits into from
May 23, 2024

Conversation

djacu
Copy link
Contributor

@djacu djacu commented May 17, 2024

Part of a larger effort captured in #966.
This was discussed at length during the last team meeting.

  • Migrates the first lesson from https://nixos-modules.nix.みんな/lessons/a-basic-module/lesson/. This was fairly straightforward; minor tweaks to code blocks and admonitions.
  • The tone has been left unchanged; it is consistent with the other lessons but inconsistent with other articles on nix.dev.
  • No "infra" has been carried over. I.e. the output from the nix and script files is static and not part of the site's build process.

@djacu djacu requested review from proofconstruction and a team as code owners May 17, 2024 03:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

🚀 Deployed on https://664f009c876d82008489d588--nix-dev.netlify.app

henrik-ch
henrik-ch reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@henrik-ch henrik-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the basic module part, and it looks good to me.
I am planning to go through the deep dive as well, but might take a bit longer as it's quite substantial.

As part of my review, I will include how long time it took for me to go through it.

djacu and others added 2 commits May 22, 2024 03:46
@djacu @fricklerhandwerk
Add first lesson for the new module tutorials.
30ea522
@fricklerhandwerk
simplify, deduplicate
cfe0f78 
- move introduction to the overview
- use nix-shell and nix-instantiate
- be a bit more precise where it seems important
- add section headings
- add more links
- cut redundant parts from the deep dive
@djacu
Copy link
Contributor Author

djacu commented May 23, 2024

@fricklerhandwerk I like the changes you have made. Looks good to me.

@fricklerhandwerk fricklerhandwerk enabled auto-merge (squash) May 23, 2024 08:35
@fricklerhandwerk fricklerhandwerk merged commit c682c68 into master May 23, 2024
11 checks passed
@fricklerhandwerk fricklerhandwerk deleted the add-first-module-lesson branch May 23, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrik-ch henrik-ch henrik-ch left review comments

@proofconstruction proofconstruction Awaiting requested review from proofconstruction proofconstruction is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djacu @henrik-ch @fricklerhandwerk