fix up wording on post-build-hook guide #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eflanagan0
added a commit
to eflanagan0/nix.dev
that referenced
this pull request
Jun 6, 2024
I noticed NixOS#993 mentions the one sentence per line convention. I found one line in `python-environment.md` that should follow that.
fricklerhandwerk
pushed a commit
that referenced
this pull request
Jun 11, 2024
I noticed #993 mentions the one sentence per line convention. I found one line in `python-environment.md` that should follow that.
djacu
previously requested changes
Jun 25, 2024
- the title was misleading, because the guide is more about hooks than S3 binary caches. - pointed Nix manual links to a fixed version - one sentence per line - linked the guide on configuring a binary cache
fricklerhandwerk
force-pushed
the
fixup-post-build-hook
branch
from
38e0319
to
d7d332f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary caches.
@proofconstruction