Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract over getrusage #10542

Open
Ericson2314 opened this issue Apr 17, 2024 · 1 comment
Open

Abstract over getrusage #10542

Ericson2314 opened this issue Apr 17, 2024 · 1 comment
Labels
good first issue Quick win for first-time contributors windows

Comments

@Ericson2314
Copy link
Member

EvalState::printStatistics uses getrusage, which is not portable to Windows. https://github.com/postgres/postgres/blob/master/src/port/win32getrusage.c is a compat shim however from venerable PostgreSQL that I think is appropriately licensed for us.

We should create a new interface in libutil for what EvalState::printStatistics needs. (It doesn't need to have the same type signature as getrusage if that helps) and then implement Windows and Unix implementations.

Originally posted by @Ericson2314 in #8901 (comment)

@Ericson2314 Ericson2314 added good first issue Quick win for first-time contributors windows labels Apr 17, 2024
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-on-windows/1113/109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Quick win for first-time contributors windows
Projects
None yet
Development

No branches or pull requests

2 participants