Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaryTarball.x86_64-linux fails at /build/install-darwin-multi-user #1752

Closed
FRidh opened this issue Dec 20, 2017 · 4 comments
Closed

binaryTarball.x86_64-linux fails at /build/install-darwin-multi-user #1752

FRidh opened this issue Dec 20, 2017 · 4 comments

Comments

@FRidh
Copy link
Member

FRidh commented Dec 20, 2017

nix-build -A binaryTarball.x86_64-linux release.nix -I nixpkgs=../nixpkgs

gives

finalPhase
build time elapsed:  0m0.316s 0m0.302s 13m42.677s 1m27.937s
building '/nix/store/g220pypa90rrkwjis7ir3lp2wk1d7nzk-nix-binary-tarball-1.12pre1234_abcdef.drv'...

In /build/install-darwin-multi-user line 156:
    printf "$BOLD%s$ESC:\t%s\n" "$1" "$2"
                        ^-- SC1117: Backslash is literal in "\t". Prefer explicit escaping: "\\t".
                            ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In /build/install-darwin-multi-user line 221:
    printf "    $ sudo %s\n" "$cmd"
                         ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".

builder for '/nix/store/g220pypa90rrkwjis7ir3lp2wk1d7nzk-nix-binary-tarball-1.12pre1234_abcdef.drv' failed with exit code 1
error: build of '/nix/store/g220pypa90rrkwjis7ir3lp2wk1d7nzk-nix-binary-tarball-1.12pre1234_abcdef.drv' failed

where Nixpkgs @ 502ebb0 and Nix @ ca40fbd

@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

Fixed in NixOS/nixpkgs#32857

@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

Sorry, that's a different issue.

@edolstra
Copy link
Member

Maybe SC1117 should be disabled in release.nix, because that check seems kind of bogus. AFAIK there is nothing wrong with doing printf "\n".

@FRidh
Copy link
Member Author

FRidh commented Dec 20, 2017

According to https://github.com/koalaman/shellcheck/wiki/SC1117 its a matter of good practice. In this case, its about being explicit that \n needs to be passed on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants