Comparison of substituter URI does not consider equivalence

[dingxiangfei2009]

Currently testing membership of a substituter URI in the set of substituters is by string comparison:

nix/src/nix-daemon/nix-daemon.cc

Line 548 in 5886bc5

if (trusted.count(s))

This will break substituters that are listed as trusted with an equivalent URI.

Steps to reproduce the issue:

1. On NixOS, or Nix with multi-user setup, export NIX_REMOTE=daemon from an untrusted user.
2. Set ~/.config/nix/nix.conf to include substituters = https://cache.nixos.org. Notice the missing slash at the end of the URI
3. nix-shell -p hello will warn about ignoring the substituter https://cache.nixos.org.

This issue can be reproduced with other substituter schema, such as ssh://<host>?<param1>&<param2>, ssh-ng://<host>?<param1>&<param2>, by specifying multiple parameters in the query string and permute them. Though the URIs are equivalent modulo the permutations, they are considered different.

[stale]

I marked this as stale due to inactivity. → More info

[stale]

I closed this issue due to inactivity. → More info