-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtins.fromGitModules #2972
Comments
Well, you're going to get hash invalidation in any case, since the importing tree needs a symlink to the module (if you're not including it into the importing tree directly). Seems simpler to add a |
@edolstra but anything that depends just on the submodule doesn't get invalidated every time the outer repo changes, and also can be cached against building from the submodule directly without the the outer repo's involvement. I'd presume that builds of the outer repo would end up depending on the inner once in any event, so I am less concerned about that. |
Yes, all the repos must be hashed seperatly. Consequently, it needs a 'source-rebuilder' - something like https://codeberg.org/maisili/aidiyz/src/commit/337e1a29e569b9251c675198fa9553328f1249ac/mkSubModulesSrc.nix |
I marked this as stale due to inactivity. → More info |
I would second the need to extract individual submodules from a flake. |
I marked this as stale due to inactivity. → More info |
And update on this? |
Whether you are using flakes or some other nix solution, there's a lot of git submodules in the wild one doesn't have authority to rewrite. Fetching all submodules together creates lots of hash invalidation, since there is one output with one hash with everything. But if we had a way to parse gitmodules into nix, we could we could make fetchgits/flakes/whatever in legacy repos for independent hashes.
The text was updated successfully, but these errors were encountered: