Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins.fromGitModules #2972

Open
Ericson2314 opened this issue Jun 25, 2019 · 7 comments
Open

builtins.fromGitModules #2972

Ericson2314 opened this issue Jun 25, 2019 · 7 comments

Comments

@Ericson2314
Copy link
Member

Whether you are using flakes or some other nix solution, there's a lot of git submodules in the wild one doesn't have authority to rewrite. Fetching all submodules together creates lots of hash invalidation, since there is one output with one hash with everything. But if we had a way to parse gitmodules into nix, we could we could make fetchgits/flakes/whatever in legacy repos for independent hashes.

@edolstra
Copy link
Member

Well, you're going to get hash invalidation in any case, since the importing tree needs a symlink to the module (if you're not including it into the importing tree directly). Seems simpler to add a submodules flag to fetchGit.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Jul 10, 2019

@edolstra but anything that depends just on the submodule doesn't get invalidated every time the outer repo changes, and also can be cached against building from the submodule directly without the the outer repo's involvement.

I'd presume that builds of the outer repo would end up depending on the inner once in any event, so I am less concerned about that.

@maisiliym
Copy link

Yes, all the repos must be hashed seperatly. Consequently, it needs a 'source-rebuilder' - something like https://codeberg.org/maisili/aidiyz/src/commit/337e1a29e569b9251c675198fa9553328f1249ac/mkSubModulesSrc.nix

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Jun 3, 2021
@FlorianFranzen
Copy link
Contributor

I would second the need to extract individual submodules from a flake.

@stale stale bot removed the stale label Jan 7, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Jul 10, 2022
@FlorianFranzen
Copy link
Contributor

And update on this?

@stale stale bot removed the stale label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants