Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Changes in v2. 7 break PackageKit ( Part II ) #6176

Closed
aakropotkin opened this issue Feb 28, 2022 · 4 comments
Closed

Header Changes in v2. 7 break PackageKit ( Part II ) #6176

aakropotkin opened this issue Feb 28, 2022 · 4 comments
Labels

Comments

@aakropotkin
Copy link
Contributor

aakropotkin commented Feb 28, 2022

Hey I wanted to recommend a bump to a new major release for some of the latest 2.7pre changes. I patched PackageKit last week after a default argument was dropped for one public interface in Nix's libexpr, but since then it looks like more breaking changes to public headers was pushed.

The call is ultimately up to you of course, but you may want to make Nix 2.7pre into Nix 3.0 when the time comes to release since many of the new changes to public interfaces aren't backwards compatible.

Again, versioning is an opinionated topic, and ultimately you're calling the shots - I just wanted to raise visibility.

I'll probably make new PRs for PackageKit and Nixpkgs again to get builds succeeding again in the next few days.

For clarity : I'm not a PackageKit maintainer; I just depend on it for some reason and since I follow Nix on main in my flakes I get hit earlier than most folks ( not complaining, I do it to help contribute ).

@aakropotkin aakropotkin changed the title Header Changes in v2. 7 break PackageKit (again) Header Changes in v2. 7 break PackageKit ( Part II ) Feb 28, 2022
@thufschmitt
Copy link
Member

Duh, I didn’t even know there was a Nix backend for PackageKit

one public interface in Nix's libexpr

Afaik, the only public interface to Nix is the CLI (not that I wouldn’t like to have a more machine-friendly interface. But it’s a non-trivial amount of work). The C++ headers are provided for convenience because some ppl want to use them, but without any guaranty of stability. Not sure what that means for PackageKit though

@edolstra
Copy link
Member

That's correct, there is no stable C++ API at the moment.

@aakropotkin
Copy link
Contributor Author

Understood.

Just as a practical matter "GNOME 3 won't build on NixOS with v2. 7pre" might be relevant to this conversation.

@thufschmitt
Copy link
Member

Just as a practical matter "GNOME 3 won't build on NixOS with v2. 7pre" might be relevant to this conversation

Indeed, just noticed that while trying to rebuild my system :)

It’s a bit unfortunate that packagekit in nixpkgs uncontitionnally builds with Nix support given that it’s relying on some unstable stuff. We should probably re-make this optional (and off by default)

Fwiw, I worked around it for the time being by overriding it to use nixStable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants