Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish a process for dealing with breaking changes #7255

Open
2 tasks done
fricklerhandwerk opened this issue Nov 2, 2022 · 8 comments
Open
2 tasks done

Establish a process for dealing with breaking changes #7255

fricklerhandwerk opened this issue Nov 2, 2022 · 8 comments
Labels
contributor-experience Developer experience for Nix contributors process Issues related to the development process of Nix

Comments

@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Nov 2, 2022

Problem

Currently there is no process for changing existing behavior (for whatever reason, but usually because it's undesired).

Checklist

Proposal

Write down a process that users can expect to be followed by maintainers.

Related:

@thufschmitt thufschmitt added process Issues related to the development process of Nix and removed documentation labels Nov 2, 2022
@fricklerhandwerk
Copy link
Contributor Author

@thufschmitt Why is this not documentation? Also I'd be really careful with creating new labels, as they tend to never go away. Deleting labels makes old issues much harder to discover. I think we already have too many.

@thufschmitt
Copy link
Member

Why is this not documentation?

Dunno, why would it be? It's not a matter of documenting something, it's a matter of designing a process. Which would have to be documented of course, but that's just a part of it, same as a new feature in code.

@abathur
Copy link
Member

abathur commented Nov 2, 2022

Presumably starts as an RFC equivalent to https://github.com/NixOS/rfcs/blob/master/rfcs/0088-nixpkgs-breaking-change-policy.md (or perhaps updates that policy to clearly cover Nix as well?)

@thufschmitt
Copy link
Member

Presumably starts as an RFC equivalent to https://github.com/NixOS/rfcs/blob/master/rfcs/0088-nixpkgs-breaking-change-policy.md (or perhaps updates that policy to clearly cover Nix as well?)

Indeed, that's certainly how things are likely to end-up. I'm not sure that we can add that to the nixpkgs policy (I'd have to re-read it, but Nix and Nixpkgs have some quite different constraints), but having this defined in an RFC seems to be the right way forward.

@roberth
Copy link
Member

roberth commented Nov 10, 2022

Presumably starts as an RFC equivalent to https://github.com/NixOS/rfcs/blob/master/rfcs/0088-nixpkgs-breaking-change-policy.md (or perhaps updates that policy to clearly cover Nix as well?)

Noting that Nixpkgs is very very free to make breaking changes because users can pin. Nix can't be pinned, and is expected to work with very old expressions. It's one of our unique selling points.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2022-12-02-nix-team-meeting-minutes-13/23731/1

@Ericson2314
Copy link
Member

#7441 is an example of the sorts of protocol incompatibility issues we are only catching manually today.

@fricklerhandwerk fricklerhandwerk added the contributor-experience Developer experience for Nix contributors label Jan 3, 2023
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-04-17-nix-team-meeting-minutes-49/27379/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors process Issues related to the development process of Nix
Projects
None yet
Development

No branches or pull requests

6 participants