New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start cross-referencing experimental features #8174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wording suggestions, otherwise let's wait for the base PR to be merged.
9159e7e
to
69c0000
Compare
Fix NixOS#8162 This is somewhat hard to observe until NixOS#8174 is merged, fixing the accidental hiding of experimental features that aren't currently enabled, but the fix is technically orthogonal.
Fix NixOS#8162 This is somewhat hard to observe until NixOS#8174 is merged, fixing the accidental hiding of experimental features that aren't currently enabled, but the fix is technically orthogonal.
69c0000
to
4ab7055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Just a few presentational issues.
- Create a glossary entry for experimental features. - Have the man page experimental feature notice link `nix-commmand`. (Eventually this should be programmed, based on whether the command is experimental, and if so what experimental feature does it depend on.) - Document which installables depend on which experimental features. I tried to use the same style (bold warning and block quote) that the top of the man page uses. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
50183b1
to
d93e76f
Compare
Thanks @fricklerhandwerk. I accepted all your changes and found a few more cases of it linking the glossary not page, and updated them accordingly. With all changes accepted and two approving reviews, I have set this to automerge :). |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-47/27387/1 |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-47/27387/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/this-month-in-nix-docs-2-april-2023/27899/1 |
Create a glossary entry for experimental features.
Have the man page experimental feature notice link
nix-commmand
.(Eventually this should be programmed, based on whether the command is experimental, and if so what experimental feature does it depend on.)
Document which installables depend on which experimental features.
I tried to use the same style (bold warning and block quote) that the top of the man page uses.
Motivation
We want to make clear what parts of the CLI are unstable and why.
If per draft RFC NixOS/rfcs#136 we end up stabilizing the CLI before flakes, it is especially important to document flakes things as such so they aren't confused with any new CLI bits that are newly stable.
Context
depnds on #7798
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.