Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise nix key #8877

Closed
fricklerhandwerk opened this issue Aug 28, 2023 · 5 comments
Closed

Stabilise nix key #8877

fricklerhandwerk opened this issue Aug 28, 2023 · 5 comments
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command RFC Related to an accepted RFC

Comments

@fricklerhandwerk
Copy link
Contributor

This implements NixOS/rfcs#136. This issue is agreed-upon by the https://github.com/orgs/NixOS/teams/nix-team

  • Make sure global flags are used consistently
  • Otherwise stabilise as is
  • Would be great if we had some default behavior for setting up keys and putting them into standard location
    • Have to figure out the details as some may have to be system-wide, some are specific to a store, etc.
@fricklerhandwerk fricklerhandwerk added idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. RFC Related to an accepted RFC labels Aug 28, 2023
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-08-28-nix-team-meeting-minutes-83/32290/1

@roberth roberth added the new-cli Relating to the "nix" command label Aug 30, 2023
@thufschmitt thufschmitt added this to the CLI Stabilisation milestone Sep 4, 2023
@thufschmitt
Copy link
Member

Closing since this doesn't provide much value.
We already track in #7701 that nix key is in the stabilisation batch, that's enough

@fricklerhandwerk
Copy link
Contributor Author

I think it's fine to keep since it's already linked in the tracking issue.

@cole-h
Copy link
Member

cole-h commented Jan 19, 2024

According to the stabilisation issue, nix key is done (has been checked off). Does that mean this issue can be closed?

@cole-h
Copy link
Member

cole-h commented Feb 7, 2024

I'm going to take the silence as a yes. If there's more to be done for preparing nix key for stabilization, let's un-tick the box in #7701 and reopen this issue with information on what, exactly, is missing.

@cole-h cole-h closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command RFC Related to an accepted RFC
Projects
Status: Done
Archived in project
Development

No branches or pull requests

5 participants