-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LocalStore
to SQLiteStore
#9552
Comments
I'm not necessarily opposed to this, but it should ideally be motivated by a real user need. Are there people who need/want a Postgres or JSON store, and if so, what for? |
|
Just my 2 cts here: the |
|
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-12-18-nix-team-meeting-minutes-113/37050/1 |
I think the purpose of that class is to implement "SQLite-ness", not "local-ness". "local-ness" is almost a non-concept: for example, building should work with any
LocalFSStore
. But even ignoring that and assuming "local-ness" still means something, the SQLite implementation is hardly the only such possible "local store", a PostgreSQL store or JSON-metadata-in-files store (https://github.com/NixOS/nix/pull/9551/files) are just in local.In light of these things, I think we should rename
LocalStore
toSQLiteStore
.(#9551 will introduce a
MixLocalStore
for a few odds and ends that are shared between local stores, and I imagine any other implementations of non-SQLite local stores would want to do the same.)Such a rename imposes a lot of churn, but I think it would be easy enough to back-port it to 2.19 and 2.18 (it's just some big seds, after all). Then it at least won't get in the way of other backports.
The text was updated successfully, but these errors were encountered: