Fix aarch64 AMI lookup and build for nixpkgs #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I know I've manually tested this functionality, it appears that I've only confirmed the automatic setting of hostPlatform, but not the AMI selection. The mistake was that I'd run it on an existing deployment where the AMI was specified manually. After instance creation, the AMI is irrelevant, and NixOps does not report anything about it. That seems to be a desirable behavior, as the original AMI *should* have no effect on the system state, and updates to the AMIs could therefore cause unnecessary messages; especially when a new NixOS comes out (amazon-ec2-amis.nix update) or when you upgrade the machines.
... for basically no other reason than testing the polyfill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for why I didn't catch it before, if you're interested.