Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hetzner plugin #45

Merged
merged 7 commits into from Jun 8, 2021
Merged

Fix Hetzner plugin #45

merged 7 commits into from Jun 8, 2021

Conversation

tewfik-ghariani
Copy link
Contributor

@tewfik-ghariani tewfik-ghariani commented May 23, 2021 •
edited

Bringing the hetzner plugin up-to-date by addressing the following :

  • Poetry2nix dependency management
  • Use of machineOptions & removal of xml parsing
  • Black & mypy & github ci
  • Re-structuring & clean-up
  • Creation of a new utils file for now since some methods were changed in nixops core : NixOS/nixops@362d049

cc @AmineChikhaoui

@tewfik-ghariani tewfik-ghariani marked this pull request as ready for review May 26, 2021 19:47
@tewfik-ghariani tewfik-ghariani marked this pull request as draft May 27, 2021 22:26
@tewfik-ghariani tewfik-ghariani marked this pull request as ready for review May 28, 2021 02:04
@AmineChikhaoui
Copy link
Member

Thanks @tewfik-ghariani . We tested this on real infra and it seemed to work fine, merging.

@AmineChikhaoui AmineChikhaoui merged commit 84f4eeb into NixOS:master Jun 8, 2021
@tewfik-ghariani tewfik-ghariani deleted the hetzner-plugin branch June 8, 2021 17:30
This was referenced Jun 8, 2021
Closed
Closed
Closed
Closed
@tewfik-ghariani tewfik-ghariani mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tewfik-ghariani @AmineChikhaoui