virtualbox.{nix,py}: add .vcpu option #540
Conversation
|
I wonder if we should instead just add something like |
|
To be honest, I think the total number of common flags could be relatively small (less than a dozen), and this offers a good way to be consistent across multiple virtualization options. I suppose this is a tradeoff between easily switching deployment providers (so you only have to learn once) and having configuration options correspond to the vendor implementation (which makes it easier if you already know your vendor). That being said, I think a |
|
Should I send up another commit that augments or replaces this commit with a |
|
It's not ideal to override vcpu to be 1 by default. It would be better to not have a default and only pass the number if it's set. |
|
@Cireo if you make that change I'll merge |
We follow the naming convention used by libvirt, and convert this option to a "--cpu" command line option for VBoxManage.
I am not sure about the handling of nullOr, some places seem to assume null values will be populated as None, others seem to assume the key will be omitted.
Cireo
force-pushed
the
vbox_vcpu_option
branch
from
e07b508
to
e38443f
Compare
|
@domenkozar sorry for the delays. I have rebased against the latest nixops master, and added the options you suggested. |
|
Thanks! |
We follow the naming convention used by libvirt, and convert this
option to a "--cpu" command line option for VBoxManage.