Make icons squared, and fix build #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
commented
Apr 9, 2024
Comment on lines
+19
to
+21
| install: grub2-installer-theme.tar.gz | ||
| mkdir -p "$(install_dest)" | ||
| tar --strip-components=1 --directory "$(install_dest)" -xf "$<" |
There was a problem hiding this comment.
This is silly, but eh, this tests the tar.gz build via the Nix output. If/when CI/CD is done in here, this ensures the tarball is "tested".
samueldr
changed the title
samueldr
changed the title
OPNA2608
reviewed
Apr 9, 2024
+ rename (to group with the coloured one) + drop pre-rendered version
+ rename to group with white version
We are not renaming the outputs, as they are used as an ad-hoc API.
Co-authored-by: Cosima Neidahl <opna2608@protonmail.com>
Co-authored-by: Cosima Neidahl <opna2608@protonmail.com>
samueldr
force-pushed
the
fix/squared-icons
branch
from
0ee6700
to
291adaf
Compare
|
Thank you for the additional nits! |
|
(I'll note that Nixpkgs has not been changed.) |
13 tasks
|
NixOS/nixpkgs#303068 for updating it in Nixpkgs. |
trueNAHO
added a commit
to trueNAHO/stylix
that referenced
this pull request
Apr 10, 2024
Addresses: NixOS/nixos-artwork#120 Closes: danth#334
danth
pushed a commit
to danth/stylix
that referenced
this pull request
Apr 10, 2024
Addresses: NixOS/nixos-artwork#120 Closes: #334
trueNAHO
added a commit
to trueNAHO/stylix
that referenced
this pull request
Apr 11, 2024
Update the SHA due to changed contents of the SVG file [1]. [1]: NixOS/nixos-artwork#120
danth
pushed a commit
to danth/stylix
that referenced
this pull request
Apr 13, 2024
Remove the 'substituteInPlace' function call because the new SVG no longer contains the matching patterns. Closes: #337 Updates the SHA due to changed contents of the SVG file: NixOS/nixos-artwork#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Closes #118
Alright, so the whole gist of it is that since even before #42 was opened I already had this problem in mind that needed to be solved.
Some early "don't want to break things" paralysis prevented me from handling this. And I never had since, for many other reasons, including lack of time and energy.
The solution is to fix the source SVG files here.
The solution also includes dropping everything from the SVG files that was not needed. Those are part of the actual main logo file. Those are artifacts derived from it. So it's fine to drop those "guide" stuff, and even the flat version of the logo.
Also renamed the pair of "snowflake-only" source svg so they are listed alphabetically together. (Also "white" really meant nothing...)
So, why all those unrelated changes?
To fix the build. I had to make those to test the Makefile changes (from the rename).
The changes don't change the semantics of the existing Makefile, but makes a bare
nix-buildinvocation build. Additionally,nix-shellnow uses facts fromdefault.nixinstead of duplicating the information and invariably diverging.