logo: add nixos-white #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
requested changes
Feb 26, 2022
There was a problem hiding this comment.
Only issue I see is the pre-baked PNG is quite big. Assuming this is intended to be used in repositories, it probably should be smaller than 9242 x 2900.
The current "for README" logo export is 1346 pixels wide, and 392 pixels high (AFAICT). Something along that ballpark is likely preferrable.
The SVG authoring is just like I would have done it.
|
@samueldr Thanks for the review. I've resized the PNG to be 392 px high |
|
Thank you! |
ryantm
added a commit
to ryantm/nixpkgs
that referenced
this pull request
Mar 10, 2022
white logo was approved in NixOS/nixos-artwork#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no clue if I did this right by this repo's standards. I used Inkscape and tried to make sure things were lined up appropriately.
fixes #79
cc @samueldr