Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dell: add XPS 9570 #134

Closed
wants to merge 1 commit into from
Closed

dell: add XPS 9570 #134

wants to merge 1 commit into from

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Dec 23, 2019

This is my current laptop that I now have in a good enough place that I'd like to share. Most of it is taken from the Arch Wiki here:

https://wiki.archlinux.org/index.php/Dell_XPS_15_9570

Note that for reasonable performance, you really do need to use the NVIDIA proprietary drivers. I won't enable it by default, but will leave the snippet I'm using in.


# TODO: boot loader
boot.loader.systemd-boot.enable = lib.mkDefault true;
boot.loader.efi.canTouchEfiVariables = lib.mkDefault true;
Copy link
Member

@Mic92 Mic92 Dec 24, 2019

Do not enable this by default. It should be only used during installation.
Enabling it by default will wear out the NVRAM since it would write new entries on every nixos-rebuild switch.

];

# TODO: boot loader
boot.loader.systemd-boot.enable = lib.mkDefault true;
Copy link
Member

@Mic92 Mic92 Dec 24, 2019

Is there anything inherently that would require systemd-boot over grub? If not than we should leave this up to the user to decide.

boot.loader.systemd-boot.enable = lib.mkDefault true;
boot.loader.efi.canTouchEfiVariables = lib.mkDefault true;

nix.buildCores = lib.mkDefault 12;
Copy link
Member

@Mic92 Mic92 Dec 24, 2019

Maybe we should make this the default in NixOS:

nix.buildCores = lib.mkDefault 0;

This sets cores equal to the number of hardware threads in a system.

{
imports = [
../../../common/cpu/intel
../../../common/pc/laptop
Copy link
Member

@Mic92 Mic92 Dec 24, 2019

If all models come with at least an ssd, we could also enable:

../../common/pc/laptop/ssd

@Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 7, 2020

Please also link your profile in the README.

@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 18, 2020

ping?

DamienCassou added a commit to DamienCassou/nixos-hardware that referenced this issue Apr 14, 2020
DamienCassou added a commit to DamienCassou/nixos-hardware that referenced this issue Apr 14, 2020
@Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 20, 2020

Closed due to lack of responsiveness. If everyone else wants to add this feel free to make a new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants