-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Travis-CI to the repo #40
Conversation
I don't think that would work because this test requires NixOS (for |
-I nixos-hardware-profile=$profile \ | ||
dry-build | ||
|
||
if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, test would never fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set -e
takes care of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Didn't know about set -e
.
fixed the test script so that it works on any system that has nix installed |
In doubt, it is possible to create VMs on non-nixos systems: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on Debian!
27d10c9
to
b8f8d9a
Compare
I think shell scripts should be portable. Also, changing evaluation rules makes it harder to reason about. Let's leave it at |
Sorry for force-pushing on top of your work, for reference, it's in fc032be7355ef8d1226fa77f0ef3a0c153e36100. Again, I think it makes the script more complex and I don't see any point in making it less verbose. |
@yegortimoshenko it's fine to disagree but please stop merging things into master while we are having a discussion. Anyways, follow-up in #44 |
@zimbatm I've only reverted your pull request to a previous state that we've agreed upon. The point of this pull request seemingly was to make Travis CI work and it works, so I've merged it. |
todo: