Add NXP i.MX8 SOC family support. #556
Conversation
|
@unbel13ver is the firmware files completely public domain to use, or are they under some license agreement that the user needs to agree to? |
|
I think in either case we would be fine to have the nix expression in this repository because the binaries are public accessible and we are not hosting repackaged versions of them (hence no copy). Might be nice though to have a license in |
Thanks for quick reply. Yes, the firmware is publicly available, but one needs to accept NXP's EULA:
I am not quilte familiar with legal stuff, so I would appreciate a lot if you point me what kind of license information I should add. |
|
Does not look like it's redistributable so I would go with |
Currently there are two devices supported: * imx8qm-mek * imx8qxp-mek Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
unbel13ver
force-pushed
the
add-mx8-support
branch
from
86bc965
to
75b6ec4
Compare
|
|
bors merge |
|
Build succeeded: |
| @@ -0,0 +1,3 @@ | |||
| final: _prev: { | |||
| inherit ( final.callPackage ./bsp/u-boot/imx8/imx-uboot.nix { pkgs = final; targetBoard = "imx8qm"; }) ubootImx8 imx-firmware; | |||
There was a problem hiding this comment.
Is ./bsp/u-boot/imx8/imx-uboot.nix correct path?
There was a problem hiding this comment.
Maybe some refactoring issues after moving the code to the repository. @unbel13ver can you fix this?
There was a problem hiding this comment.
Hi, sorry for this. I'll fix paths and improve README
| @@ -0,0 +1,3 @@ | |||
| final: prev: { | |||
| inherit ( final.callPackage ./bsp/u-boot/imx8/imx-uboot.nix { pkgs = final; targetBoard = "imx8qxp"; }) ubootImx8 imx-firmware; | |||
There was a problem hiding this comment.
./bsp/u-boot/imx8/imx-uboot.nix no u-boot/imx8 directory in bsp. Also relative path of bsp doesn't seem ok.
There was a problem hiding this comment.
Relative paths are ok as long as they point within the repo directory structure.
This was an overside in NixOS#556
Currently there are two devices supported:
Signed-off-by: Ivan Nikolaenko ivan.nikolaenko@unikie.com
Description of changes
Changes made in the way it makes very easy to add another mx8-based device or device-specific configuration.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input