Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Techstack-beta] Missing active state in top navigation #1246

Closed
samueldr opened this issue Mar 1, 2024 · 1 comment · Fixed by #1265
Closed

[Techstack-beta] Missing active state in top navigation #1246

samueldr opened this issue Mar 1, 2024 · 1 comment · Fixed by #1265
Assignees
@thilobillerbeck
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 1, 2024 •
edited
Loading

Top, the old navigation. Bottom, the new navigation.

image

There is no active state for the current page in the menu (where possible).

Since this is a new stack, the plan always was to have sub-pages show the section as active. So e.g. a team page would have the community link active. (The previous stack did not allow for that.)

Also an issue in narrow view

image
@samueldr samueldr added the design About the design refresh work label Mar 1, 2024
@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 1, 2024
@thilobillerbeck
Copy link
Collaborator

yeah I noticed this already, something with not seeing the wood for the trees :D

will be fixed shortly

@samueldr samueldr changed the title [Techstack-beta] Missing activate state in top navigation [Techstack-beta] Missing active state in top navigation Mar 2, 2024
@thilobillerbeck thilobillerbeck self-assigned this Mar 2, 2024
@thilobillerbeck thilobillerbeck mentioned this issue Mar 2, 2024
Merged
@thilobillerbeck thilobillerbeck linked a pull request Mar 3, 2024 that will close this issue
fix 1235, 1246, 1248 and download page regresisons #1265
Merged
thilobillerbeck added a commit that referenced this issue Mar 3, 2024
@thilobillerbeck @garbas
fix 1235, 1246, 1248 and download page regresisons (#1265)
90f8e1f 
- fix #1235
- fix #1246
- fix #1248
- fix #1272 
- fix #1271 
- fix #1270 
- fix #1267 
- fix #1266 
- fix #1263 
- fix #1262
- fix #1283
- fix #1282
- fix #1280
- fix #1278
- fix some regressions on the download page (though not all)

---------

Co-authored-by: Rok Garbas <rok@garbas.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thilobillerbeck thilobillerbeck

Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 1235, 1246, 1248 and download page regresisons NixOS/nixos-homepage
2 participants
@samueldr @thilobillerbeck