Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve mobile sponsor logo sizing #1341

Closed
thilobillerbeck opened this issue Mar 13, 2024 · 0 comments · Fixed by #1344
Closed

improve mobile sponsor logo sizing #1341

thilobillerbeck opened this issue Mar 13, 2024 · 0 comments · Fixed by #1344
Assignees
@thilobillerbeck
Labels
design About the design refresh work

Comments

@thilobillerbeck
Copy link
Collaborator

Describe the glitch
On some mobile devices the current scaling of the sponsor logos seems to fail. This screenshot tries to mimic what happens on a Google Pixel 7a.

Screenshots
nixos org_donate_
@thilobillerbeck thilobillerbeck added the design About the design refresh work label Mar 13, 2024
@thilobillerbeck thilobillerbeck mentioned this issue Mar 15, 2024
Merged
@thilobillerbeck thilobillerbeck self-assigned this Mar 21, 2024
garbas added a commit that referenced this issue Mar 22, 2024
@thilobillerbeck @garbas
Update Astro Icon, Inline SVGs (#1344)
7df9f33 
- update astro icon
- add iconify icon packs
- inline several SVGs using InlineSVG component
- inline some svgs using tailwindcss
- sets fallback text for headings to serif to avoid massive font jumping
on load
- add blue background to header to avoid flashes on load
- fixes #1341 as well

With this PR there is no network dependency left for the build process

---------

Co-authored-by: Rok Garbas <rok@floxdev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thilobillerbeck thilobillerbeck

Labels
design About the design refresh work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Astro Icon, Inline SVGs NixOS/nixos-homepage
1 participant
@thilobillerbeck