Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nix expression" on package search results links to wrong URLs #372

Closed
das-g opened this issue Mar 28, 2020 · 4 comments
Closed

"Nix expression" on package search results links to wrong URLs #372

das-g opened this issue Mar 28, 2020 · 4 comments
Projects

Comments

@das-g
Copy link
Member

das-g commented Mar 28, 2020

E.g., for bash on NixOS 19.09, it currently displays

Nix expression /build/source/pkgs/shells/bash/4.4.nix

which links to https://github.com/NixOS/nixpkgs/blob/undefined//build/source/pkgs/shells/bash/4.4.nix#L110, which leads to a 404 "Page not found" error page.

It should probably be something like https://github.com/NixOS/nixpkgs/blob/nixos-19.09/pkgs/shells/bash/4.4.nix#L110 instead., i.e.

nixos-19.09

(or whatever the channel name of the search result is)

instead of

undefined//build/source
@garbas garbas added this to Confirmed in TODO Mar 29, 2020
edolstra added a commit to NixOS/nixpkgs that referenced this issue Mar 29, 2020
edolstra added a commit to NixOS/nixpkgs that referenced this issue Mar 29, 2020
@grahamc grahamc reopened this Mar 29, 2020
@das-g
Copy link
Member Author

das-g commented Mar 29, 2020

Um, now the website says

Nix expression Not specified

Is that intended? Is it just a temporary artefact and the actual information will come back?

@edolstra
Copy link
Member

Yes, it will be back once packages.json contains a commit field.

@rkoe
Copy link

rkoe commented Apr 10, 2020

Yes, it will be back once packages.json contains a commit field.

When will that be?
Because the "Nix expression" links were quite useful.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/package-search-issues/6735/3

@garbas garbas moved this from Confirmed to Done in TODO May 7, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
TODO
Done
Development

No branches or pull requests

5 participants