fix redirects once again #1451
Merged
fix redirects once again #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
thilobillerbeck
approved these changes
May 28, 2024
|
Deployment seems to have failed: https://github.com/NixOS/nixos-homepage/actions/runs/9271085525/job/25505642925 How to diagnose this? @garbas this looks like some infra issue I have no visibility into. |
1 task
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/documentation-links-from-google-are-broken/46144/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f1fbfc and 5f00e55 were a confused about old and new URL formats, and it didn't help that very similar-looking redirects were in multiple locations of the file.
this change brings them together and should restore all existing URLs and correctly point them to nix.dev.
closes #1448 - sorry everyone for the disruption, and thanks again for pointing out the breakages. ping me directly if anything else around the Nix manual falls apart.