nix/install: Rewrite to not rely on bashisms. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of [[ ... ]] and provides a fallback to "which" if the "type" builtin is not available. Also, this now longer relies on "set -e", because we're checking the errors carefully by ourselves and properly clean up whenever there was an error. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Older versions of tar didn't detect the compression type and thus tried to extract an uncompressed archive and even older versions of tar didn't even have the -j argument at all, so let's download, decompress and unpack in one go. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig
force-pushed
the
install-without-bashisms
branch
from
3ec81f2
to
f84c795
Compare
Of course, the install script from Nix itself will use bash, but that's an entirely different case. The problem with the install instructions itself is that it even relied on bash for its "<()" syntax. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
|
Is it actually a problem to rely on bashisms? The supported platforms (Linux, Darwin) generally have bash. BTW, the `wrap()' thingy is necessary to prevent execution of a partially downloaded script. |
|
Also, |
|
Indeed, And yes, on these platforms it's usually not a problem to rely on bashisms, but it shortens the installation command line by two characters and doesn't hurt if we one day should support platforms without bash :-) |
As @edolstra pointed out, this is to prevent execution of a partially downloaded script. So let's reintroduce the wrapper with a comment to make sure it won't be removed again. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
|
Applied, thanks! |
wmertens
added a commit
to wmertens/nix
that referenced
this pull request
Sep 24, 2014
edolstra
pushed a commit
to NixOS/nix
that referenced
this pull request
Sep 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of
[[ ... ]]and provides a fallback towhichif thetypebuiltin is not available.This now longer relies on "set -e", because we're checking the errors carefully by ourselves and properly clean up whenever there was an error.
Also, we no longer download into a temporary file but download, decompress and extract on the fly. The main reason for this is because older tar versions don't either detect the compression type or even do not have
-jat all.