Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] Changing channel does not reload the contents without an action #65

Closed
samueldr opened this issue Jun 5, 2020 · 0 comments · Fixed by #80
Closed

[review] Changing channel does not reload the contents without an action #65

samueldr opened this issue Jun 5, 2020 · 0 comments · Fixed by #80

Comments

@samueldr
Copy link
Member

samueldr commented Jun 5, 2020

As part of the review for NixOS/nixos-homepage#454


The dropdown is after the search "action", but requires backtracking to be taken into consideration.

  • Enter search terms
  • Activate Search button
  • Change channel
  • Observe the contents have not refreshed

I would expect the channel results to change since the search button is intimately linked to the input box.

A solution would involve placing the channel selection before the action button. If we think hierarchically, the channel is at the "root" of the tree for our taxonomy, in a way. I think this means that the channel selection should be before the search box. Though it would be fine before the button, and after the search query, but harder to integrate in the flow visually.

I know that it is by design that results don't change when inputs change, but I believe the drop down could be an exception to this rule, considering its position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant