Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[review] Options description are not parsing docbook contents #67

Closed
samueldr opened this issue Jun 5, 2020 · 0 comments · Fixed by #86
Closed

[review] Options description are not parsing docbook contents #67

samueldr opened this issue Jun 5, 2020 · 0 comments · Fixed by #86
Labels
bug Something isn't working

Comments

@samueldr
Copy link
Member

samueldr commented Jun 5, 2020

As part of the review for NixOS/nixos-homepage#454

This is a major downgrade, and a pretty major issue.

Compare services.firefox.syncserver.enable.

This also currently directly uses the bytes without consideration for XSS!!!!

See how it's been done in the previous implementation for known cases.
@samueldr samueldr added the bug Something isn't working label Jun 5, 2020
garbas added a commit that referenced this issue Jun 11, 2020
@garbas
Fix how we display default/example/description of an option
14f055c 
* description is now converted to html at import time
* default/example should now realize what is an non-value and what is
  "None" (as string) value

fixes #69
fixes #67
@garbas garbas mentioned this issue Jun 11, 2020
Merged
garbas added a commit that referenced this issue Jun 11, 2020
@garbas
Fix how we display default/example/description of an option (#86)
7f2ed39 
* description is now converted to html at import time
* default/example should now realize what is an non-value and what is
  "None" (as string) value

fixes #69
fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix how we display default/example/description of an option NixOS/nixos-search
1 participant
@samueldr