Fix mobile only interactions #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbas
approved these changes
Jan 20, 2021
garbas
deleted the
turboMaCk/revert-4d505f34022154a1f193f012c11eb08d07c90271
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 4d505f3 and removes only unused dependencies of bootstrap (jquery-ui and font awesome). Responsive parts of bootstrap depends on javascript which itself depends on jQuery. We need to be careful around these areas though because Elm doesn't like when something mutates the dom (causes exceptions in function that applies vdom to the dom). #266
I think these changes should not conflict with #261 and thus this patch can be merged while faceted-search is being worked on.
Fixes #266