Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dynamic import #473

Merged
merged 35 commits into from Apr 24, 2022
Merged

Feat/dynamic import #473

merged 35 commits into from Apr 24, 2022

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 20, 2022

was #455

dasJ and others added 23 commits March 29, 2022 19:56
1. add nixos-org-configurations as input to flake.nix
2. evaluate channels.nix file and export channels via environment variable.
   that environment variable (lets call it NIXOS_CHANNELS) should be present
   during the build and inside the nix shell. the content of the variable can
   be JSON.
3. we pickup the NIXOS_CHANNELS environment variable in
   frontend/webpack.config.js and pass it further to webpack process, just
   like we do with ELASTICSEARCH_MAPPING_SCHEMA_VERSION.
4. we forward NIXOS_CHANNELS to Elm via frontend/src/index.js as an Elm
   application flag. Just like we do with other variables there.
Co-authored-by: Naïm Favier <n@monade.li>
but still provide devShells for each of the subprojects
and define lib = nixpkgs.lib before the call to eachDefaultSystem
Also, version = lib.fileContents ./VERSION;
Co-authored-by: Naïm Favier <n@monade.li>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 19:42 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 19:44 Inactive
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:22 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:31 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:32 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:35 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:41 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 22:43 Inactive
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to pull request April 21, 2022 07:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 21, 2022 07:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 24, 2022 21:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 24, 2022 21:31 Inactive
@garbas
Copy link
Member Author

garbas commented Apr 24, 2022

And finally a successful import https://github.com/NixOS/nixos-search/actions/runs/2216914043

@garbas garbas merged commit eea6cd3 into main Apr 24, 2022
@garbas garbas deleted the feat/dynamic-import branch April 24, 2022 21:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-29/18903/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants