Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nix-vscode-extensions #601

Merged
merged 1 commit into from
Jan 23, 2023
Merged

add nix-vscode-extensions #601

merged 1 commit into from
Jan 23, 2023

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Jan 23, 2023

Hi, @ncfavier, @figsoda ! I'd like to add a flake with ~40K VS Code extensions and ~3K Open VSX extensions that get updated daily.

@ncfavier
Copy link
Member

ncfavier commented Jan 23, 2023

Same issue as #530

Even if it did work, I'm skeptical of the value of adding 43K entries to nixos-search that are basically a mirror of https://marketplace.visualstudio.com/vscode

@deemp
Copy link
Contributor Author

deemp commented Jan 23, 2023

Hi, @ncfavier! The goal is to let people create per-project VS Code setups. Currently, we try to make people aware of this opportunity via nixos-search. I moved the extensions to a separate attrset, so nix flake check works. We'd like to publish the flake and expose vscodium-with-extensions. The flake description will provide a link to the repo. So, no need to publish all 43K extensions. Could you please check?

Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay now

@ncfavier ncfavier merged commit 8f14293 into NixOS:main Jan 23, 2023
@deemp
Copy link
Contributor Author

deemp commented Jan 23, 2023

Thanks!

@figsoda
Copy link
Member

figsoda commented Jan 23, 2023

@deemp btw I don't have write access to this repository, 7abecfe was just a squashed merge authored by me and merged by @ncfavier

@deemp
Copy link
Contributor Author

deemp commented Jan 23, 2023

@figsoda, sorry for mention then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants