-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victorshoup do you think this should be upstreamed? Darwin doesn't have g++, requiring this patch to build ntl on darwin.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. BTW,
stdenv.cc.isClang
would be more precise, though I don't know about any other standard nixpkgs configurations using clang stdenv.1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record: @victorshoup is the upstream ntl maintainer (author?), which is why I pinged him here.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note if this commit is under discussion, I think a cleaner way to do this would have been to set the CXX makefile variable.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the issues are exactly, but why not: ./configure CXX=c++
NOTE: NTL's configure script does not read environment variables (I admit that it probably should), so export CXX=c++; ./configure doesn't work.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the configure script should use
c++
instead ofg++
as both GCC and llvm/clang provide that.1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that! Maybe I should change NTL's configure script to make that the default. There used to be some arcane reason why I preferred g++ to c++, but I don't remember what it was.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I make a new pull request to use configure flags instead of modifying
DoConfig
?1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, pushed directly as ef6b76c, for simplicity.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason the configure script doesn't respect environment variables? I think if that was the case our build system would take care of it automatically.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1bfbe76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for your input :) The solution now is definitely good enough for us, just consider it a "nice to have" feature request at the bottom of your priority list.