Skip to content

Commit

Permalink
nixos/tests/networking.virtual: prevent non-deterministic failure (#4…
Browse files Browse the repository at this point in the history
…6949)

The test failed non-deterministically on Hydra because interfaces
sometimes weren't yet fully cleaned up when the result was checked.

(cherry picked from commit 0565996)
  • Loading branch information
xeji committed Sep 20, 2018
1 parent 43809bd commit d5cbdec
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion nixos/tests/networking.nix
Expand Up @@ -467,7 +467,7 @@ let
# Wait for networking to come up
$machine->start;
$machine->waitForUnit("network.target");
$machine->waitForUnit("network-online.target");
# Test interfaces set up
my $list = $machine->succeed("ip tuntap list | sort");
Expand All @@ -479,7 +479,9 @@ let
# Test interfaces clean up
$machine->succeed("systemctl stop network-addresses-tap0");
$machine->sleep(10);
$machine->succeed("systemctl stop network-addresses-tun0");
$machine->sleep(10);
my $residue = $machine->succeed("ip tuntap list");
$residue eq "" or die(
"Some virtual interface has not been properly cleaned:\n",
Expand Down

0 comments on commit d5cbdec

Please sign in to comment.