Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.tz is incompatible with new tzdata format #102937

Closed
roberth opened this issue Nov 5, 2020 · 7 comments
Closed

haskellPackages.tz is incompatible with new tzdata format #102937

roberth opened this issue Nov 5, 2020 · 7 comments
Labels
0.kind: bug 0.kind: regression Something that worked before working no longer 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: haskell 9.needs: port to stable A PR needs a backport to the stable release.

Comments

@roberth
Copy link
Member

roberth commented Nov 5, 2020

Describe the bug

Build failure.
Example:
https://hydra.nixos.org/build/129855941/nixlog/1

Upstream is working on a solution. nilcons/haskell-tz#26
When available, master can pick up the new hackage package. 20.09 will require a backport.

To Reproduce

  1. In nixpkgs master, run nix-build haskellPackages.tz

Expected behavior

Build successfully.

Screenshots

Additional context

Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
@roberth roberth added 0.kind: bug 6.topic: haskell 9.needs: port to stable A PR needs a backport to the stable release. 0.kind: regression Something that worked before working no longer labels Nov 5, 2020
@roberth roberth mentioned this issue Nov 5, 2020
2 tasks
@flokli
Copy link
Contributor

flokli commented Nov 5, 2020

ExpectedButGot Nothing "2013-10-27 01:00:00" "2013-10-27 02:00:00"

Apparently, there were similar assumptions in the test code. File issue upstream and disable tests in the meantime?

@roberth
Copy link
Member Author

roberth commented Nov 5, 2020

No. tz isn't the only program that's incompatible with the new format. We've broken other packages assuming it was just impure test churn. See #102946

@roberth
Copy link
Member Author

roberth commented Nov 5, 2020

Upstream issue already exists for tz. Other issues idk, but I'm already a couple of rabbitholes deep...

@flokli

This comment has been minimized.

@roberth

This comment has been minimized.

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@roberth
Copy link
Member Author

roberth commented Jun 5, 2021

#102946 has solved the practical problem for NixOS users and other distros seem to take the same approach. I don't see a reason to switch to the slim format again. It'd be nice for upstream to implement this, but it's not relevant for nixpkgs anymore.

@roberth roberth closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 0.kind: regression Something that worked before working no longer 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: haskell 9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Development

No branches or pull requests

2 participants