Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Improve blockchain stuff organization and consistency #103890

Open
RaghavSood opened this issue Nov 15, 2020 · 6 comments
Open

Housekeeping: Improve blockchain stuff organization and consistency #103890

RaghavSood opened this issue Nov 15, 2020 · 6 comments
Labels
0.kind: enhancement 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: community feedback

Comments

@RaghavSood
Copy link
Member

RaghavSood commented Nov 15, 2020

I would like to clean up our blockchain packages and modules a bit.

There's a number of small issues which make production level deployments somewhat harder to deal with. This effort would mostly be in reorganizing the actual layout of the derivations in the package tree, and on the modules.

This issue is intended to serve as a living cleanup tracker and will be updated with actionable items during the cleanup process as well as due to any discussions below.

Some of the key issues I intend to tackle are:

  1. Better organization of the blockchain packages - rippled is floating on its own in pkgs/servers, most of the others are in pkgs/applications/blockchains
  2. Of the stuff in pkgs/applications/blockchains, some is in bare derivations at the top level, some are in folders, and it's all mixed together with non-nodes such as electrum (a wallet, not a node)
  3. Some of the stuff is far out of date, either because there are issues with building the updates (such as zcash) or because things have changed upstream with no active maintainers here (parity rebranding to openethereum for the ETH client, etc)
  4. The modules are in varying states of completeness - Bitcoin is in pretty good shape, especially with the new named instances update, but many others don't reflect the current configuration set, or have very little configuration available. It would be good to have some consistency here, such as named instances for all nodes, more complete module configuration surface, and removal of deprecated options.
  5. We're missing many newer nodes such as Algorand - I have derivations for many of these which we use internally (I work at an exchange), and will be upstreaming them

I'm also happy to take over maintainership of many of the unmaintained packages, as well as do all of the above as cleanup and housekeeping.

Would be interested in hearing any other proposals or objections

@RaghavSood
Copy link
Member Author

cc @adisbladis @prusnak @mmahut

@mmahut
Copy link
Member

mmahut commented Nov 15, 2020

@RaghavSood thank you for working on this! Of course, any improvement to the current situation is very welcome.

@veprbl veprbl removed the 6.topic: module system About NixOS module system internals label Nov 15, 2020
@Mic92
Copy link
Member

Mic92 commented Nov 17, 2020

Go for it!

@RaghavSood RaghavSood mentioned this issue Nov 30, 2020
10 tasks
@bachp
Copy link
Member

bachp commented Dec 6, 2020

@RaghavSood I'm currently working on better support for Ethereum which seems relevant to this issue.

@RaghavSood
Copy link
Member Author

@bachp That's great! Let me know if you need any help or review - I've been working on putting together derivations for other ethereum based projects like BSC etc.

My current (rough) plan is to start by doing top level organization in the form of blockchain/ethereum, blockchain/bitcoin etc, followed by various nodes at a second level for each network (such as bitcoind and btcd).

Next would be to standardize the modules to follow the current bitcoin module form of named services, so that testnets and mainnets can run concurrently.

Let me know if there is anything I can help with!

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: community feedback
Projects
None yet
Development

No branches or pull requests

6 participants