tlsh output does not include the binary

[petersjt014]

Describe the bug
Building tlsh is meant to produce both a library and an application. The current definition only does the former.

To Reproduce
Steps to reproduce the behavior:

1. nix-shell -p pythonPackages.tlsh (or python37Packages etc)
2. command tlsh is not found
3. do something jank like ls -R /nix/store/*python?.?-tlsh*, confirm that the expected binary is not present.

Expected behavior
tlsh can be run as a command.

Additional context
Since it's both an application and a library, I don't think the standard buildPythonApplication will work.

Notify maintainers
Erm... nobody?

Metadata

• system: "x86_64-linux"
• host os: Linux 5.4.77, NixOS, 20.09.2161.214e71a78a9 (Nightingale)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.3.9
• channels(root): "nixos-20.09.2161.214e71a78a9"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: don't know
# a list of nixos modules affected by the problem
module: don't know

Diffoscope will affected if the fixed definition does not produce a library.

[petersjt014]

Three other things:

• The version is way out of date. Couldn't hurt to bump it.
• The tests seem to fail only because /bin/bash isn't found. Should be a simple fix.
• Here is an IRC conversation about the problem.

[petersjt014]

I've tried adding a buildPhase manually. Here's the tail end of the build log:

Scanning dependencies of target simple_unittest
[ 68%] Building CXX object test/CMakeFiles/simple_unittest.dir/simple_unittest.cpp.o
[ 75%] Linking CXX executable ../../../bin/simple_unittest
[ 75%] Built target simple_unittest
Scanning dependencies of target tlsh_unittest
[ 81%] Building CXX object test/CMakeFiles/tlsh_unittest.dir/tlsh_unittest.cpp.o
[ 87%] Linking CXX executable ../../../bin/tlsh_unittest
[ 87%] Built target tlsh_unittest
Scanning dependencies of target rand_tags
[ 93%] Building CXX object utils/CMakeFiles/rand_tags.dir/rand_tags.cpp.o
[100%] Linking CXX executable ../../../bin/rand_tags
[100%] Built target rand_tags
/build/source/build/release
Running tests...
Test project /build/source/build/release
    Start 1: tlsh_unittest_len
Process not started
 /build/source/Testing/test.sh
[no such file or directory]
1/2 Test #1: tlsh_unittest_len ................***Not Run   0.00 sec
    Start 2: tlsh_unittest_xlen
Process not started
 /build/source/Testing/test.sh
[no such file or directory]
2/2 Test #2: tlsh_unittest_xlen ...............***Not Run   0.00 sec

0% tests passed, 2 tests failed out of 2

Total Test time (real) =   0.01 sec

The following tests FAILED:
          1 - tlsh_unittest_len (BAD_COMMAND)
          2 - tlsh_unittest_xlen (BAD_COMMAND)
Errors while running CTest
make: *** [Makefile:81: test] Error 8
builder for '/nix/store/a3mvqlrgja9xli179hy6li7k0917hjbs-python2.7-tlsh-3.4.5.drv' failed with exit code 2
error: build of '/nix/store/a3mvqlrgja9xli179hy6li7k0917hjbs-python2.7-tlsh-3.4.5.drv' failed

I'm not sure how to deal with those two tests.

[stale]

I marked this as stale due to inactivity. → More info

[Artturin]

Arch ref https://github.com/archlinux/svntogit-community/blob/packages/tlsh/trunk/PKGBUILD