Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC all-packages inherit descriptive list #119201

Open
happysalada opened this issue Apr 12, 2021 · 1 comment
Open

RFC all-packages inherit descriptive list #119201

happysalada opened this issue Apr 12, 2021 · 1 comment
Labels
0.kind: question 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@happysalada
Copy link
Contributor

Issue description

in the all-packages.nix there are places where there is a inherit with a long list. Examples are
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L2052
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L10077
and
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L11599

To be sure, we are talking about something that looks like

inherit (beam.interpreters)
    erlang erlangR23 erlangR22 erlangR21 erlangR20 erlangR19 erlangR18
    erlang_odbc erlang_javac erlang_odbc_javac erlang_basho_R16B02
    elixir elixir_1_11 elixir_1_10 elixir_1_9 elixir_1_8 elixir_1_7;

It does feel like there would be a way to do a recursive inherit, however I haven't found a way.

I have 2 questions

  • Is there a way to do a recursive inherit
  • Even if there was, what would be the prefered coding style?
    I personally prefer outputs being listed clearly, it's easier for other people to grep. However it can feel tedious to other maintainers to list everything explicitely.

The reason I am asking is that there is a discussion about it, and it doesn't really feel it belongs in the PR.

Sorry if this feels like bike-shedding.

@SuperSandro2000 don't really know what tags to add and who to involve here.

@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: question 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

2 participants