Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black nixos test linting #121066

Closed
blaggacao opened this issue Apr 28, 2021 · 2 comments
Closed

black nixos test linting #121066

blaggacao opened this issue Apr 28, 2021 · 2 comments

Comments

@blaggacao
Copy link
Contributor

${python3Packages.black}/bin/black --check --diff $out/test-script

This linting is good but it should ignore line length as there might be unpredictable valuables (e.g. nix store paths) rendered into the scripts that break in arbitrary instances.

eg:

      kube.wait_until_succeeds(
          "kubectl apply -f ${config.kubernetes.result}"
      )

or

      kube.wait_until_succeeds("kubectl apply -f ${config.kubernetes.result}")

depends solely on the length of the actual config.kubernetes.result string.

@dotlambda
Copy link
Member

dotlambda commented May 1, 2021

Duplicate of #72964

@dotlambda dotlambda marked this as a duplicate of #72964 May 1, 2021
@blaggacao
Copy link
Contributor Author

Thanks @dotlambda !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants