Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass show -c doesn't copy to clipboard #17296

Closed
eikek opened this issue Jul 27, 2016 · 9 comments
Closed

pass show -c doesn't copy to clipboard #17296

eikek opened this issue Jul 27, 2016 · 9 comments

Comments

@eikek
Copy link
Member

eikek commented Jul 27, 2016

Issue description

I recently updated to nixos-unstable, now its 16.09pre87381.ddb7588 (Flounder). If I use pass (the password manager) like this

pass show -c some/entry

the clipboard doesn't contain the password. If I use nixos-unstable at commit 125ffff, it works.

Steps to reproduce

  • install X and pass
  • log into x
  • run pass show -c some/entry (create it, if necessary: pass generate some/entry 10)

Technical details

  • System: NixOS: 16.09pre87381.ddb7588 (Flounder)
  • Nix version: nix-env (Nix) 1.11.2
  • Nixpkgs version: 16.09pre87431.3badad8
@cfricke
Copy link

cfricke commented Jul 27, 2016

This is related to #17267. pass uses bash's exec -a to overwrite the password in the clipboard after $CLIP_TIME passes. exec currently fails, therefore overwrites the password right away.

@anderspapitto
Copy link
Contributor

I'm also hitting this

@eikek
Copy link
Member Author

eikek commented Sep 29, 2016

Now, at current nixos-unstable (which is nixos 17.03pre92039.adfcc2d (Gorilla)) it works.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2016

I think: 493ab7b fixed this. This is not included in the version you reported.

@eikek
Copy link
Member Author

eikek commented Sep 29, 2016

Ok, this is strange then. I tested it like this:

pass show -c some/entry
xclip -o -selection clipboard

I can use all my pass key bindings as before, too. So for me it works :) The version I reported is the output from nixos-version.

@nixy
Copy link
Contributor

nixy commented Apr 8, 2017

It looks like the patch from 493ab7b was removed from pass in edcbb6d. I am not sure why this was removed as this still doesn't seem to work for me. Additionally this patch was never applied to the version of clip() used in darwin as that clip() function resides in lib/password-store/platform.sh.

Would it be possible to get this patch added again and also make sure it works for darwin?

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2017

maybe @fpletz can explain why it was dropped.

@eikek
Copy link
Member Author

eikek commented Apr 19, 2017

For me, this issue can be closed. How does it work? Am I supposed to close my issues or rather a nixos maintainer?

@nixy
Copy link
Contributor

nixy commented Apr 19, 2017

I believe my PR should have fixed this across the board here. Since this is no longer an issue for you, or seemingly anyone else, you can close it. Be the master of your own destiny ;)

@eikek eikek closed this as completed Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants