Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message for bad mkOption call #203848

Open
roberth opened this issue Dec 1, 2022 · 1 comment
Open

Bad error message for bad mkOption call #203848

roberth opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
0.kind: bug 6.topic: module system About "NixOS" module system internals

Comments

@roberth
Copy link
Member

roberth commented Dec 1, 2022

Describe the bug

If I mess up the mkOption call, not even the eval trace shows which option contains the mistake.

Steps To Reproduce

Steps to reproduce the behavior:

See
https://hercules-ci.com/github/hercules-ci/flake.parts-website/jobs/154

I'm pretty sure I'm the one who messed up, but maybe next time it will be an error I don't recognize.

Expected behavior

mkOption error's show-trace contains the path to the option.

@roberth roberth self-assigned this Dec 1, 2022
@roberth
Copy link
Member Author

roberth commented Dec 1, 2022

Update: I guess the trace does contain a file location, but that I'm not sure that will always make the location obvious. An option path may be more specific, and having both the location and the option both would be nice.

@veprbl veprbl added 6.topic: windows Running, or buiding, packages on Windows 6.topic: module system About "NixOS" module system internals and removed 6.topic: windows Running, or buiding, packages on Windows labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 6.topic: module system About "NixOS" module system internals
Projects
None yet
Development

No branches or pull requests

2 participants